Does this make sense?

If I want to say I have been looking for (object) for X years. Do I says?

これまで X 年間このような様々な (object) を探しています。

これまで X 年間このような様々な (object) を探しています。

I would remove 様々な, because このような already says "(object) like this," so it would blur the object too much if you say "various."

In what context are you referring to?
There are two kanjis for "look for"
探す means to look for, i.e. a hotel, a doctor, clothes, etc. 　
捜す means to look for that disappeared, i.e. a key, a wallet, a missing person, a criminal, etc.
Also if you want to emphasize the time and found the object, then,
(もうかれこれ)ｘ年間も、この様な(object)を探していました。
But if you had it before but misplaced, lost, disappeared, and it showed up finally, then,
(もうかれこれ)ｘ年間も、この(object)を捜していました。